feat: Add standard tomogram badge to tomogram selector #1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janeece
requested changes
Sep 26, 2024
There was a problem hiding this comment.
Thanks @bchu1 - The tags look good, but the font weights should be regular instead of semibold. This is not a blocker, but a "should have" for consistency.
- Should have - input dropdown font weights appear to be all semibold, only the tomogram name (the "label") should be semibold.
- Change voxel spacing & tomogram badge to be regular weight so that it will align with the SDS patterns
- Should have - dropdown menu text font weights appear to be all semibold, only Menu Item name on the selected menu item should be semibold
- Change all detail text & the tomogram badge to regular weight
- confirm that for unselected menu items, the tomogram name is also regular weight (in screenshot this case isnt relevant since there is only 1 tomogram)
Updated the screenshot! |
Janeece
approved these changes
Sep 27, 2024
ehoops-cz
approved these changes
Sep 30, 2024
| 'h-[20px] px-sds-xs py-sds-xxxs !text-sds-body-xxxs text-[#002660] leading-sds-body-xxxs rounded inline-flex bg-[#e9f1ff]', | ||
| 'inline-flex items-center px-sds-xs py-sds-xxxs', | ||
| '!text-sds-body-xxxs text-[#002660] font-normal leading-sds-body-xxxs rounded bg-[#e9f1ff]', | ||
| size === 'small' ? 'h-[16px]' : 'h-[20px]', |
There was a problem hiding this comment.
16px is sds-l, there's nothing for 20px though, so not sure if it makes sense to replace one and not the other.
There was a problem hiding this comment.
didn't know we could use that with h-, yeah if it only works for one I'll just leave it
bchu1
force-pushed
the
bchu/download
branch
from
edef56b to
1c9be19
Compare
github-actions bot
added a commit
that referenced
this pull request
Oct 3, 2024
🤖 I have created a release *beep* *boop* --- ## [1.31.0](web-v1.30.0...web-v1.31.0) (2024-10-03) ### ✨ Features * Add portal standard badge to tomograms table and integrate alignment metadata accordion with new API ([#1179](#1179)) ([1de70a1](1de70a1)) * Add standard tomogram badge to tomogram selector ([#1181](#1181)) ([ac4ad27](ac4ad27)) * Add tooltip to Alignment ID field in tomogram sidebar ([#1196](#1196)) ([fad5207](fad5207)) * Integrate more V2 API queries ([#1174](#1174)) ([92f80a7](92f80a7)) * Migrate and start using tomograms query in UI ([#1169](#1169)) ([d21ffd9](d21ffd9)) * Undo changes for transforming annotations and add new callout for mismatched alignments ([#1191](#1191)) ([ea1598d](ea1598d)) * update annotation row name ([#1163](#1163)) ([6164201](6164201)) * Update to generic annotation transformation callout during download ([#1186](#1186)) ([5597524](5597524)) ### 🐞 Bug Fixes * address misc UI/UX bugs ([#1192](#1192)) ([178737d](178737d)) * change incorrect deposition links ([#1133](#1133)) ([dc642e5](dc642e5)) * Stop querying depositionTitle ([#1187](#1187)) ([07a08d4](07a08d4)) ### 🧹 Miscellaneous Chores * prefix IDs across the portal ([#1178](#1178)) ([1732fb2](1732fb2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1005
The messed up paddings are tracked in #1158