feat: Initial support for apiv2 #1085
Conversation
There was a problem hiding this comment.
Generally looks good, and I'm happy that the codegen module didn't need to be changed much.
After setting up an v2 backend, I was able to run some quick manual tests, so agreed this seems to be kinda working. Lots of the list relationships give empty lists, but that could just be due to the local test infra fakes.
With the new version of the backend, can we specify comments/descriptions on the item/list relationships? That was not possible with hasura, so I just had to autogenerate those descriptions with sometimes awkward results (e.g. The alignment this per section alignment parameters is a part of).
| "tiltseries": "TiltSeries", | ||
| "depositions": "Deposition", | ||
| "deposition_authors": "DepositionAuthor", | ||
| "Alignment": "Alignment", |
There was a problem hiding this comment.
If these are always expected to be identical now, maybe this should just be a tuple of gql/model names instead of a mapping?
| of_type = get_named_type( | ||
| get_named_type(field_type.fields["edges"].type).fields["node"].type | ||
| ) |
There was a problem hiding this comment.
Nit: I find this chained call pretty hard to read. Consider unwrapping it with something like.
| of_type = get_named_type( | |
| get_named_type(field_type.fields["edges"].type).fields["node"].type | |
| ) | |
| edges_type = get_named_type(field_type.fields["edges"].type) | |
| of_type = get_named_type(edges_type.fields["node"].type) |
names in the client.
jgadling
changed the title
client/python/cryoet_data_portal/src/cryoet_data_portal/_gql_base.py
Outdated
Show resolved
Hide resolved
Release-As: 4.0.0
This is a checkpoint: Basic relationships and filters work, but I haven't had a chance to test all of the filter operators and update test infra yet. --------- Co-authored-by: uermel <[email protected]>
This is a checkpoint: Basic relationships and filters work, but I haven't had a chance to test all of the filter operators and update test infra yet.
BEGIN_COMMIT_OVERRIDE
feat!: Initial support for apiv2 (#1085)
END_COMMIT_OVERRIDE