Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the success message shorter #80

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make the success message shorter #80

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52292c8
Make the success message shorter than the failure message and tweak t…
eoghanmurray Nov 7, 2023
451eddf
Further make the 'success' version shorter. Think the tick mark is mo…
eoghanmurray Nov 8, 2023
784aec4
On second thoughts, the 'More Info' link could be construed as referr…
eoghanmurray Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,14 @@ const getReleasePlanMessage = (releasePlan: ReleasePlan | null) => {
}),
]);

return `<details><summary>This PR includes ${
return `<details><summary>This PR ${
releasePlan.changesets.length
? `changesets to release ${
? `will increment versioning on the next release of the following ${
publishableReleases.length === 1
? "1 package"
? "package"
: `${publishableReleases.length} packages`
}`
: "no changesets"
: "includes no changesets"
}</summary>

${
Expand All @@ -57,11 +57,11 @@ const getAbsentMessage = (
commitSha: string,
addChangesetUrl: string,
releasePlan: ReleasePlan | null
) => `### ⚠️ No Changeset found
) => `### ⚠️ No Changeset found ⚠️

Latest commit: ${commitSha}

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.**
Merging this PR will **not** cause a version bump for any packages. If these changes should not result in a new version, you're good to go. **If these changes should result in a version bump, you need to add a changeset.**

${getReleasePlanMessage(releasePlan)}

Expand All @@ -75,18 +75,11 @@ const getApproveMessage = (
commitSha: string,
addChangesetUrl: string,
releasePlan: ReleasePlan | null
) => `### 🦋 Changeset detected
) => `### ✅ Changeset detected [ⓘ](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md)

Latest commit: ${commitSha}

**The changes in this PR will be included in the next version bump.**
[Add Another Changeset](${addChangesetUrl})

${getReleasePlanMessage(releasePlan)}

Not sure what this means? [Click here to learn what changesets are](https://github.com/changesets/changesets/blob/main/docs/adding-a-changeset.md).

[Click here if you're a maintainer who wants to add another changeset to this PR](${addChangesetUrl})

`;

const getNewChangesetTemplate = (changedPackages: string[], title: string) =>
Expand Down