Skip to content

Commit

Permalink
fix changesets
Browse files Browse the repository at this point in the history
This PR introduces a BREAKING CHANGE considering that the environment variable for the `NPM_TOKEN` secret is changed. Even though this is changed in the default case when the action itself writes the `.npmrc` file, this could break if the file is custom-written beforehand or if subsequent steps read from the environment variable directly.
  • Loading branch information
yaacovCR committed Feb 26, 2023
1 parent fd1877d commit e276a67
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions .changeset/brave-buckets-double.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@changesets/action": major
---

use `NODE_AUTH_TOKEN` as the environment variable name for the `NPM_TOKEN` secret

This matches the official GitHub `setup-node` action (documentation)[https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages#publishing-packages-to-the-npm-registry].
4 changes: 2 additions & 2 deletions .changeset/light-yaks-search.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"@changesets/action": patch
---

match `NPM_TOKEN`'s environment variable name to official documentation
write environment variable references to files instead of the values

= use `NODE_AUTH_TOKEN` as the environment variable name, which matches the official GitHub `setup-node` action documentation.= when writing the `.npmrc` file, write the environment variable name reference, rather than the variable value.
Within the `.npmrc` and `.netrc` files, write references to `NODE_AUTH_TOKEN` and `GITHUB_TOKEN` rather than the actual values.

0 comments on commit e276a67

Please sign in to comment.