Fix calculation of FP

chakki-works · Aug 25, 2020 · 2ca0aba · 2ca0aba
1 parent e7dfa83
commit 2ca0aba
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/seqeval/metrics/sequence_labeling.py b/seqeval/metrics/sequence_labeling.py
@@ -265,18 +265,18 @@ def performance_measure(y_true, y_pred):
 
     Example:
         >>> from seqeval.metrics import performance_measure
-        >>> y_true = [['O', 'O', 'O', 'B-MISC', 'I-MISC', 'O', 'B-ORG'], ['B-PER', 'I-PER', 'O']]
-        >>> y_pred = [['O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'O', 'O'], ['B-PER', 'I-PER', 'O']]
+        >>> y_true = [['O', 'O', 'O', 'B-MISC', 'I-MISC', 'O', 'B-ORG'], ['B-PER', 'I-PER', 'O', 'B-PER']]
+        >>> y_pred = [['O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'O', 'O'], ['B-PER', 'I-PER', 'O', 'B-MISC']]
         >>> performance_measure(y_true, y_pred)
-        {'TP': 3, 'FP': 2, 'FN': 1, 'TN': 4}
+        {'TP': 3, 'FP': 3, 'FN': 1, 'TN': 4}
     """
     performace_dict = dict()
     if any(isinstance(s, list) for s in y_true):
         y_true = [item for sublist in y_true for item in sublist]
         y_pred = [item for sublist in y_pred for item in sublist]
     performace_dict['TP'] = sum(y_t == y_p for y_t, y_p in zip(y_true, y_pred)
                                 if ((y_t != 'O') or (y_p != 'O')))
-    performace_dict['FP'] = sum(((y_t != 'O') != (y_p != 'O')) for y_t, y_p in zip(y_true, y_pred))
+    performace_dict['FP'] = sum(((y_t != y_p) and (y_p != 'O')) for y_t, y_p in zip(y_true, y_pred))
     performace_dict['FN'] = sum(((y_t != 'O') and (y_p == 'O'))
                                 for y_t, y_p in zip(y_true, y_pred))
     performace_dict['TN'] = sum((y_t == y_p == 'O')

diff --git a/tests/test_metrics.py b/tests/test_metrics.py
@@ -40,11 +40,11 @@ def test_get_entities_with_suffix_style(self):
         self.assertEqual(get_entities(y_true, suffix=True), [('MISC', 3, 5), ('PER', 7, 8)])
 
     def test_performance_measure(self):
-        y_true = [['O', 'O', 'O', 'B-MISC', 'I-MISC', 'O', 'B-ORG'], ['B-PER', 'I-PER', 'O']]
-        y_pred = [['O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'O', 'O'], ['B-PER', 'I-PER', 'O']]
+        y_true = [['O', 'O', 'O', 'B-MISC', 'I-MISC', 'O', 'B-ORG'], ['B-PER', 'I-PER', 'O', 'B-PER']]
+        y_pred = [['O', 'O', 'B-MISC', 'I-MISC', 'I-MISC', 'O', 'O'], ['B-PER', 'I-PER', 'O', 'B-MISC']]
         performance_dict = performance_measure(y_true, y_pred)
         self.assertDictEqual(performance_dict, {
-                             'FN': 1, 'FP': 2, 'TN': 4, 'TP': 3})
+                             'FN': 1, 'FP': 3, 'TN': 4, 'TP': 3})
 
     def test_classification_report(self):
         print(classification_report(self.y_true, self.y_pred))