This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
vis_keypoint --> vis_point #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hakuyume
reviewed
Feb 27, 2018
| all keypoints in :obj:`keypoint` will be displayed. | ||
| of the points. | ||
| mask (~numpy.ndarray, optional): A boolean array whose shape is | ||
| :math:`(P,)`. If :math:`i` th index is :obj:`True`, the |
There was a problem hiding this comment.
:math:i th index -> :math:i th element
Hakuyume
reviewed
Mar 5, 2018
| :math:`i` th keypoint is not displayed. If not specified, | ||
| all keypoints in :obj:`keypoint` will be displayed. | ||
| of the points. | ||
| mask (~numpy.ndarray, optional): A boolean array whose shape is |
There was a problem hiding this comment.
optional in the type description may be against to our convention.
c.f. https://github.com/chainer/chainercv/blob/master/chainercv/visualizations/vis_bbox.py#L27-L29
|
|
||
| cm = plot.get_cmap('gist_rainbow') | ||
|
|
||
| colors = [cm(1. * i / n_kp) for i in six.moves.range(n_kp)] | ||
| colors = [cm(1. * i / n_point) for i in six.moves.range(n_point)] |
There was a problem hiding this comment.
You can write cm(i / n_point) with from __feature__ import division.
Hakuyume
reviewed
Mar 6, 2018
| mask (~numpy.ndarray): A boolean array whose shape is | ||
| :math:`(P,)`. If :math:`i` th element is :obj:`True`, the | ||
| :math:`i` th point is not displayed. If not specified, | ||
| all points in :obj:`point` will be displayed. | ||
| ax (matplotlib.axes.Axes, optional): If provided, plot on this axis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is based on the new naming convention (
keypoint, kp_mask --> point, mask) #507