Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nfppreprocessor return is real node #298

Closed

Conversation

corochann
Copy link
Member

Please merge after #296

@corochann
Copy link
Member Author

This PR will change the NFPPreprocessor's behavior to output is_real_node.
I will proceed to the same thing for GGNNPreprocessor after PR merged.

@corochann corochann requested a review from mottodora December 20, 2018 11:10
@codecov-io
Copy link

codecov-io commented Dec 20, 2018

Codecov Report

Merging #298 into master will increase coverage by 0.08%.
The diff coverage is 98.3%.

@@            Coverage Diff             @@
##           master     #298      +/-   ##
==========================================
+ Coverage   83.64%   83.73%   +0.08%     
==========================================
  Files         174      174              
  Lines        7987     8030      +43     
==========================================
+ Hits         6681     6724      +43     
  Misses       1306     1306

@corochann
Copy link
Member Author

example test ok.

@mottodora mottodora added this to the 0.6.0 milestone Feb 7, 2019
@corochann
Copy link
Member Author

-> #311

@corochann corochann closed this Apr 18, 2019
@corochann corochann deleted the nfppreprocessor_return_is_real_node branch October 3, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants