Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet Onboarding web page 개선 #1318

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Wallet Onboarding web page 개선 #1318

wants to merge 4 commits into from

Conversation

blacktoast
Copy link
Collaborator

구현사항

  • 특정 버튼이 viewport에 없을 경우 해당 버튼으로 이동 하는 함수인checkButtonPositionAndScrollToButton를 구현했습니다.
  • enable-chains에서 chainItem들이 다 렌더링될때 까지 임의로 500ms 기다린뒤 checkButtonPositionAndScrollToButton 실행하도록 적용
  • addvaced가 있는 페이지의 경우 해당 버튼을 클릭했을때 하단 버튼이 내려갔을경우 해당 버튼으로 스크롤이 이동되도록 checkButtonPositionAndScrollToButton을 적용

Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-wallet-extension ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 7:57am

@blacktoast blacktoast marked this pull request as ready for review February 13, 2025 07:57
Copy link
Member

@delivan delivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants