Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates on EarnOverview/TokenDetail #1317

Merged

Conversation

editaahn
Copy link
Collaborator

  • Earn 관리 페이지: 상단부 Claimable / Balance 섹션 UI (History는 백엔드 구현 후 작업 가능해서 제외)
  • 토큰 디테일에 Earn 배너, 버튼 UI
  • (+) 번역 변경된 부분 수정 (작업 겹칠 수 있어서 제가 작업하던 퍼널 내에서만 수정했습니다.)

@editaahn editaahn requested review from Thunnini and delivan February 13, 2025 06:18
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-wallet-extension ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 6:19am

"page.earn.estimation-confirm.usdc-to-usdn.swap-button": "Swap",
"page.earn.estimation-confirm.usdn-description.title": "How does USDN work?",
"page.earn.estimation-confirm.usdn-description.paragraph.first": "The Noble Dollar (USDN) is a stablecoin built on M^0's canonical stablecoin, $M, which is backed by short-term U.S. Treasury bills.",
"page.earn.estimation-confirm.usdn-description.paragraph.second": "Swap USDC for USDN, hold it, and earn real-time rewards. Deposit or withdraw anytime—no lock-up. Learn More",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아직 Learn More 랜딩 어디로 할지 미결정 상태

Comment on lines +18 to +21
// TO-DO: use readymade query later
const claimableAmountRes = queriesStore.simpleQuery.queryGet<{
amount: string;
}>(rest, `/noble/dollar/v1/yield/${bech32Address}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 To-do가 나중에 stores 패키지에 쿼리 만드신다는 뜻이죠?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@delivan 넵 이거 정환님이 작업하셨다고 해서 추후 업데이트를 위해 To-do로 남겨뒀어요.

@editaahn editaahn requested a review from delivan February 17, 2025 06:25
Copy link
Member

@delivan delivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@editaahn editaahn merged commit 404288b into chainapsis:Thunnini/noble Feb 18, 2025
4 checks passed
@editaahn editaahn deleted the editaahn/keplr-810/keplr-828 branch February 18, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants