Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm bridge 배포 최종 pr #1302

Open
wants to merge 53 commits into
base: develop
Choose a base branch
from
Open

evm bridge 배포 최종 pr #1302

wants to merge 53 commits into from

Conversation

blacktoast
Copy link
Collaborator

@blacktoast blacktoast commented Feb 3, 2025 •
edited
Loading

구현 사항

아래 3개의 pr이 머지된 최종 배포 pr 입니다
#1292
#1305
#1309

@blacktoast
[feat] add select destination bridge chain
7c67e4c
@blacktoast
[feat] change isIBCtransfer to sendType
4bcb014
@blacktoast
[feat] change DestinationChainView that can get chainInfo instead of …
4b1320c 
…IbcChannelConfig
@blacktoast
[refactor] separate some login inside hook for readability
e4a2b05
@blacktoast
[feat] change isIBCRecipientSetAuto name and logic for birdge
693a2ea
@blacktoast
[fix] fix bug that when chain is not evmOnly chain, sender set of hex…
8f2e3fe 
…Address
@blacktoast
[fix] fix that recent address isn't recorded when tx is eth tx
0c4c2cc
@blacktoast
[feat] add logic when destination address is hex, set recipient addre…
499c0a2 
…ss hex
@blacktoast
[refactor] change hook name, and unify duplicated logic about config
d261e6a
@blacktoast
[feat] Fix where isSwapDestinationOrAlternatives is used to prevent r…
126cf09 
…eset observations
@blacktoast
[refactor] delete comment
35e9899
@blacktoast
[chore] remove unused properties
892828c
@blacktoast
[refactor] change import path
12ecbb3
@blacktoast
[feat] reflect review
9813002 
- Change logic for finding assets  for performance from using asset to using assetRaw
@blacktoast
Revert "[feat] Fix where isSwapDestinationOrAlternatives is used to p…
ccee894 
…revent reset observations"

This reverts commit 126cf09.
@blacktoast
[fix] fix that it happen to call get assets function frequently
0529f06
@blacktoast
Merge pull request #1292 from chainapsis/retto/add-evm-bridging-1
e4aecc2 
�evm 브릿지 1차 pr
@vercel Vercel
Copy link

vercel bot commented Feb 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-wallet-extension ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 6:24am

@blacktoast blacktoast changed the title Retto/add evm bridge evm bridge 배포 최종 pr Feb 12, 2025
@blacktoast blacktoast requested review from Thunnini, delivan and piatoss3612 and removed request for delivan February 12, 2025 05:50
@blacktoast blacktoast marked this pull request as ready for review February 12, 2025 06:04
@Thunnini Thunnini changed the base branch from master to develop February 12, 2025 07:06
Thunnini
Thunnini requested changes Feb 12, 2025
View reviewed changes
Copy link
Member

@Thunnini Thunnini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getCacheKey()에도 각각 request에 맞춰서 수정해주세요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thunnini Thunnini Thunnini requested changes

@piatoss3612 piatoss3612 Awaiting requested review from piatoss3612

@delivan delivan Awaiting requested review from delivan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blacktoast @Thunnini