-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to webp 1.4.0 Closes #74 #41 #55 #61 #60 #73
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hiram Chirino <[email protected]>
Signed-off-by: Hiram Chirino <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read all the new Go code (there is extremely little!) and used this branch in a tool of my own that makes use of many of this library's features successfully.
FWIW, I'm happy this can be merged — is there anything else I can help with here @chai2010?
You can test this branch in your project by dropping the following in your go.mod
file, and running go mod tidy
:
replace github.com/chai2010/webp => github.com/chirino/webp webp-1.4.0
@chirino, on the off chance this does get merged, if you add "Closes #74 #41 #55 #61 #60" to your PR description it'll close the related issues & PRs.
The replace syntax throws an error for me. Is this a version number? |
@seantiz its a branch name - do check out the go mod docs and see if I've made a mistake there! (I'm away from a computer for the next few weeks or I'd check myself!) |
@jphastings Hi, any updates of when these fix will be released? |
@andriamirul You’d have to ask the owner of the repo. I think it’s abandoned 😔 |
No description provided.