Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Double colour profile read fix (fixes #121) #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

guywillis
Copy link
Contributor

Fixes #121

Fix

  • Add aria-hidden to label
  • Add aria-label to <select> element
  • Added a11y import

@guywillis guywillis added the bug label Feb 6, 2025
@guywillis guywillis self-assigned this Feb 6, 2025
@oliverfoster
Copy link
Member

You'll need to do the same to all of them

@guywillis
Copy link
Contributor Author

You'll need to do the same to all of them

Do you mean the rest of the options (checkboxes / button groups) within the visua11y overlay or how the HTML is laid out within the jsx template?

@oliverfoster
Copy link
Member

Don't the check boxes suffer the same problem?

@guywillis
Copy link
Contributor Author

guywillis commented Feb 7, 2025

Nope, checkboxes are fine.

There is an argument to be made for the readability button groups though as they read out like:

"Font size"
"Font size, radio group"

so there is a duplication of information that the checkboxes do not have.

@kirsty-hames
Copy link
Contributor

Nope, checkboxes are fine.

There is an argument to be made for the readability button groups though as they read out like:

"Font size" "Font size, radio group"

so there is a duplication of information that the checkboxes do not have.

We can resolve the duplication by applying aria-hidden='true' to the .visua11ysettings__item-title. The label will still be read by the radiogroup aria-labelledby.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JAWS reads colour profile twice
3 participants