Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Ensure _customRouteId model is available before displaying button (fixes #71) #72

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix: Ensure _customRouteId model is available before displaying button (fixes #71) #72

merged 1 commit into from
Jun 25, 2024

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jun 25, 2024 •
edited
Loading

Fix #71

Fix

  • When using _customRouteId, ensure the content object model is available (_isAvailable: true). If not, do not display the button.
  • This will still allow pages to be navigated to when they are hidden with _isHidden: true

@swashbuck swashbuck self-assigned this Jun 25, 2024
@swashbuck swashbuck added the bug label Jun 25, 2024
@oliverfoster oliverfoster merged commit 7078745 into master Jun 25, 2024
1 check passed
@oliverfoster oliverfoster deleted the issue/71 branch June 25, 2024 18:54
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 3.1.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@oliverfoster oliverfoster mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@swashbuck swashbuck

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using _customRouteId skips _isAvailable check
2 participants
@swashbuck @oliverfoster