-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error Alert Updates #881
Error Alert Updates #881
Conversation
Let's get this in front of Natalia, I'll put it up on the dev environment. |
@ojbravo @billhimmelsbach Since we are using a bottom error footer, do we want to keep the UX where the user is scrolled to the error header? |
|
I think the original behavior works for now with the scroll, but let's briefly ask Natalia at the next dev/design sync if we want to make improvements here in future tickets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too! Excited to get this merged.
Closes #865