[Design Review] [Resolve Errors] [Review Warnings] #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ear Save and continue button
…ear Save and continue button -- full Alert
shindigira
changed the title
shindigira
changed the title
meissadia
reviewed
May 14, 2024
src/index.css
Outdated
Comment on lines
56
to
59
| td { | ||
| background-color: transparent !important; | ||
| } |
There was a problem hiding this comment.
Odd that this is needed but I'm not able to spot why the striped background is appearing.
I think we should consider making this a more tightly scoped class to avoid blocking future devs from being able to add striped tables if needed.
Something like table.no-stripes > td
There was a problem hiding this comment.
For sure! I'll leave this in and put a TODO note.
cfpb/design-system-react#345
There was a problem hiding this comment.
Heyo! Let's label these @shindigira with a post-mvp label even in the design-system-react repo, just so we can grab all of them easily later. 👍
meissadia
reviewed
May 14, 2024
meissadia
reviewed
May 14, 2024
meissadia
reviewed
May 14, 2024
src/pages/Filing/FilingApp/FilingWarnings/FilingWarningsAlerts.tsx
Outdated
Show resolved
Hide resolved
meissadia
reviewed
May 14, 2024
There was a problem hiding this comment.
Looks good! I'll let @meissadia take another peek and give the final approval!
meissadia
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #485
closes #488
closes #481
closes #482
Note
yarn installto get the DSR updatesChanges
total_countto a filing typeTodo
word breakand handling large character setsreact-hook-formerror handling the verify warnings section @meissadia