Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerts] Update on Resolve Errors + Warnings pages #865

Closed
ojbravo opened this issue Aug 8, 2024 · 3 comments · Fixed by #881
Closed

[Alerts] Update on Resolve Errors + Warnings pages #865

ojbravo opened this issue Aug 8, 2024 · 3 comments · Fixed by #881
Assignees

Comments

@ojbravo
Copy link
Contributor

ojbravo commented Aug 8, 2024

Update language and position of alerts on Resolve Errors and Warnings pages.

Mock-ups:

Resolve errors (syntax)
Screenshot 2024-08-08 at 4 55 10 PM

Resolve errors (logic)
Screenshot 2024-08-05 at 4 55 42 PM

Review warnings
This one replaces the existing field-level alert.
Screenshot 2024-08-05 at 4 55 51 PM

@ojbravo ojbravo self-assigned this Aug 8, 2024
@ojbravo
Copy link
Contributor Author

ojbravo commented Aug 16, 2024

These are the actual screenshots:

Resolve errors (syntax):
errorAlert-syntax

Resolve errors (logic):
errorAlert-logic

Review Warnings:
errorAlert-warnings

@natalia-fitzgerald
Copy link

@ojbravo
Can you double check that the text in these messages is styled as paragraph text (16px, Regular weight) and not H4? It looks correct in the first set of screenshots but in the second one it looks like it changed to H4?

@ojbravo
Copy link
Contributor Author

ojbravo commented Sep 10, 2024

@ojbravo Can you double check that the text in these messages is styled as paragraph text (16px, Regular weight) and not H4? It looks correct in the first set of screenshots but in the second one it looks like it changed to H4?

At present, the DSR component defaults to 'h4' and only allows h1 - h6. I've created a ticket in the DSR to allow for non-headings: cfpb/design-system-react#378

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants