-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(alert): no wrapper class when no message provided (#389)
Currently when there's no message but has children (explanations), then a `m-notification_explanation` applied which makes it not possible to achieve designs like these (unbolded, aligned text): <img width="1143" alt="Screenshot 2024-11-19 at 4 13 26 PM" src="https://github.com/user-attachments/assets/e78ff4a4-6c08-4df8-9455-4e6648a57701"> <img width="648" alt="Screenshot 2024-11-19 at 4 16 46 PM" src="https://github.com/user-attachments/assets/6f053344-afef-4b12-a8fe-4efcf264cc8c"> ## Changes - if there is no message, but still has children then do not apply `m-notification_explanation` to allow alert flexibility ## How to test this PR 1. Do the tests pass? 2. How do the examples look? 3. Try modifying the package.json to point the DSR to this commit and see how the alerts are affected. ## Screenshots <img width="1346" alt="Screenshot 2024-11-19 at 4 21 12 PM" src="https://github.com/user-attachments/assets/add6b874-260f-4e77-b6a8-6ddbeb5ecfbb">
- Loading branch information
1 parent
874fdba
commit 87e95f8
Showing
3 changed files
with
28 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters