Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATAP-1619 Upgraded to ESLint v9 for CCDB UI #572

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

cdmh219
Copy link
Collaborator

@cdmh219 cdmh219 commented Jan 14, 2025

Upgraded CCDB UI to use ESLint v9. This included use of the updated flat configuration format, and will work for both the actual application and related Cypress tests.

Additions

  • New config file eslint.config.mjs (with flat configuration)

Removals

  • Old config file .eslintrc
  • Unnecessary rules for React Hooks and React-Redux (many aren't supported by ESLint v9, and should be covered by eslint-plugin-react)

Changes

  • Reordering of functions in several files to guarantee use of defined functions everywhere

Testing

  • Run yarn run lint and ensure no errors/warnings are present
  • Run yarn test to ensure all unit tests still run as expected with updated config
  • Run yarn run cypress run to ensure all automated high-level tests still run as expected with updated config

Screenshots

Notes

Todos

Checklist

  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the front end playbook
  • Passes all existing automated tests
  • New functions include new tests
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged
  • Visually tested in supported browsers and devices
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)

@cdmh219 cdmh219 requested a review from flacoman91 January 14, 2025 16:32
…module, as opposed to making all js files modules by default in the package.json file
@cdmh219 cdmh219 changed the title Initial upgrades and updates to config rules DATAP-1619 Upgraded to ESLint v9 for CCDB UI Jan 14, 2025
@cdmh219 cdmh219 marked this pull request as ready for review January 14, 2025 18:06
@cdmh219 cdmh219 requested a review from flacoman91 January 14, 2025 18:06
@cdmh219 cdmh219 requested a review from flacoman91 January 15, 2025 17:54
Chanel Henley and others added 4 commits January 15, 2025 12:55
Copy link
Contributor

@flacoman91 flacoman91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for taking care of this!

@flacoman91 flacoman91 added this pull request to the merge queue Jan 15, 2025
Merged via the queue into main with commit cdab141 Jan 15, 2025
2 checks passed
@flacoman91 flacoman91 deleted the DATAP-1619-ESLint-v9-Upgrade branch January 15, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants