-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DATAP-1619 Upgraded to ESLint v9 for CCDB UI #572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flacoman91
reviewed
Jan 14, 2025
src/components/Filters/Aggregation/AggregationItem/AggregationItem.js
Outdated
Show resolved
Hide resolved
…module, as opposed to making all js files modules by default in the package.json file
flacoman91
reviewed
Jan 14, 2025
# Conflicts: # dist/ccdb5.js # dist/ccdb5.js.map # yarn.lock
flacoman91
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for taking care of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded CCDB UI to use ESLint v9. This included use of the updated flat configuration format, and will work for both the actual application and related Cypress tests.
Additions
eslint.config.mjs
(with flat configuration)Removals
.eslintrc
Changes
Testing
yarn run lint
and ensure no errors/warnings are presentyarn test
to ensure all unit tests still run as expected with updated configyarn run cypress run
to ensure all automated high-level tests still run as expected with updated configScreenshots
Notes
Todos
Checklist