Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: scanner redeems page #508

Merged
merged 7 commits into from
Feb 9, 2025
Merged

feat: scanner redeems page #508

merged 7 commits into from
Feb 9, 2025

Conversation

joaodiaslobo
Copy link
Member

@joaodiaslobo joaodiaslobo commented Feb 9, 2025 •
edited
Loading

image

image

@joaodiaslobo joaodiaslobo self-assigned this Feb 9, 2025
ruioliveira02
ruioliveira02 previously approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only annoyance I have is the button to redeem is not perfectly circular (on my machine it is 4 pixels wider than taller), but we are beyond the point where that is a problem. Good job!

@joaodiaslobo
Copy link
Member Author

@ruioliveira02 fixed the button's circularity !! 😁

ruioliveira02
ruioliveira02 approved these changes Feb 9, 2025
View reviewed changes
Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩

@joaodiaslobo joaodiaslobo merged commit 368447e into main Feb 9, 2025
2 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/scanner-redeems-page branch February 9, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruioliveira02 ruioliveira02 ruioliveira02 approved these changes

@nunom27 nunom27 Awaiting requested review from nunom27

@Darguima Darguima Awaiting requested review from Darguima

@MarioRodrigues10 MarioRodrigues10 Awaiting requested review from MarioRodrigues10

@AfonsoMartins26 AfonsoMartins26 Awaiting requested review from AfonsoMartins26

Assignees

@joaodiaslobo joaodiaslobo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaodiaslobo @ruioliveira02