Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: activity enrollments #477

Merged
merged 11 commits into from
Feb 4, 2025
Merged

feat: activity enrollments #477

merged 11 commits into from
Feb 4, 2025

Conversation

ruioliveira02
Copy link
Member

It stills needs some work, but I would like your opinion on the following:

I think the button should be visible even if the user is logged in. However, in that case, the user is redirected to the log in page.

I believe it would be best if, after logging in, the user be automatically enrolled in the activity (assuming they already confirmed through the browser pop-up). However, I am struggling to see a solution that doesn't envolve a controller (as log in does not use LiveView). What do you think?

@ruioliveira02 ruioliveira02 self-assigned this Jan 24, 2025
@ruioliveira02 ruioliveira02 force-pushed the ro/activity-enrollments branch from c15a96b to 87f4ed3 Compare January 24, 2025 17:40
@ruioliveira02 ruioliveira02 force-pushed the ro/activity-enrollments branch from 7f708b0 to 0c764c9 Compare February 1, 2025 18:32
@ruioliveira02 ruioliveira02 marked this pull request as ready for review February 1, 2025 18:33
@joaodiaslobo
Copy link
Member

Make sure that when an attendee enrolls in an activity, it instantly updates the buttons to prevent them enrolling in the other ones that happen at the same time.

@joaodiaslobo
Copy link
Member

joaodiaslobo commented Feb 4, 2025

@ruioliveira02
I don't really like how the enrolment UI logic is both in the home and in the schedule (duplicated).
Also, the browser dialog can be used on the backoffice, but for attendee views I'd prefer to use an actual modal.
Considering there isn't too much time to spend on this, I'd like to hear from you if these issues can be solved. If not, it gets merged as it is.

@ruioliveira02
Copy link
Member Author

@ruioliveira02 I don't really like how the enrolment UI logic is both in the home and in the schedule (duplicated). Also, the browser dialog can be used on the backoffice, but for attendee views I'd prefer to use an actual modal. Considering there isn't too much time to spend on this, I'd like to hear from you if these issues can be solved. If not, it gets merged as it is.

So the first issue I agree and solved it already (I had to turn schedule into a live_component ). The modal is going to be tricky, because the component that exists is used in the backoffice, so it is light mode. I think we would have to redesign it from scratch, so I don't think it is viable to do it now.

@joaodiaslobo joaodiaslobo merged commit 418716b into main Feb 4, 2025
2 checks passed
@joaodiaslobo joaodiaslobo deleted the ro/activity-enrollments branch February 4, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants