feat: add makefile modules for local dev #1452
Conversation
Signed-off-by: Adam Talbot <[email protected]>
jetstack-bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
size/XXL
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Tim Ramlot <[email protected]>
|
@ThatsMrTalbot I think we also need a |
Sure, we can add that. I was not too concerned with that initially since this is only used for local dev (mainly for vendoring nodejs locally tbh) |
|
There were quite a few people who told me that setting up node and npm for this project is complex and that this PR will improve their experience. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cert-manager-prow
bot
added
the
approved
This adds makefile-modules to the repo, this gives us:
make helpconsistent with the other reposnodeandnpmare vendored in _bin like we do for all other toolsmake buildandmake devto simply development (no need to install node/npm)