Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add announcements section to the website #1435

Merged
merged 8 commits into from
Mar 18, 2024
Merged

feat: add announcements section to the website #1435

merged 8 commits into from
Mar 18, 2024

Conversation

ThatsMrTalbot
Copy link
Contributor

No description provided.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 5, 2024
@ThatsMrTalbot ThatsMrTalbot force-pushed the feat/announcements-section branch 3 times, most recently from db8326e to 98b982e Compare March 5, 2024 13:35
@netlify Netlify
Copy link

netlify bot commented Mar 5, 2024 •
edited
Loading

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 526f9f2
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65f49a6784524800085692b6
😎 Deploy Preview https://deploy-preview-1435--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ThatsMrTalbot ThatsMrTalbot changed the title feat: add announcements section to the website WIP feat: add announcements section to the website Mar 5, 2024
@jetstack-bot jetstack-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 5, 2024
inteon
inteon reviewed Mar 5, 2024
View reviewed changes
lib/announcements.js Outdated Show resolved Hide resolved
@ThatsMrTalbot ThatsMrTalbot force-pushed the feat/announcements-section branch 3 times, most recently from 884b330 to 5964509 Compare March 5, 2024 14:10
SgtCoDFish
SgtCoDFish reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a few suggestions for this - what do you think?

(I'm not saying this is a list of changes we must make - just suggesting stuff to add to the conversation around this!)

content/announcements/2024-03-04-cert-manager-security-audit.md Outdated Show resolved Hide resolved
content/announcements/2024-03-04-cert-manager-security-audit.md Outdated Show resolved Hide resolved
content/announcements/2024-03-04-cert-manager-security-audit.md Outdated Show resolved Hide resolved
content/announcements/2024-03-04-cert-manager-security-audit.md Outdated Show resolved Hide resolved
content/announcements/2024-03-04-cert-manager-security-audit.md Outdated Show resolved Hide resolved
content/announcements/2024-03-04-cert-manager-security-audit.md Outdated Show resolved Hide resolved
@ThatsMrTalbot ThatsMrTalbot force-pushed the feat/announcements-section branch 2 times, most recently from 02f40cf to d519567 Compare March 6, 2024 11:37
@ThatsMrTalbot ThatsMrTalbot changed the title WIP feat: add announcements section to the website feat: add announcements section to the website Mar 15, 2024
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 15, 2024
inteon
inteon reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold

@jetstack-bot jetstack-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 15, 2024
inteon
inteon reviewed Mar 15, 2024
View reviewed changes
content/announcements/2024-03-15-cert-manager-security-audit.md Outdated
slug: cert-manager-security-audit
title: cert-manager completes CNCF-sponsored security audit!
description: As part of our graduation processes cert-manager has completed a security audit of the project
date: 03-15-2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible future improvement: change the date format

wallrj
wallrj approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the look of the new Announcements and I proof read the announcement its self and found it very easy to read.

I have not reviewed the JavaScript, but the page loaded fine and the links worked in Microsoft Edge Version 122.0.2365.80 (Official build) (64-bit).

/lgtm
/hold in case there are any remaining changes or suggestions.

@jetstack-bot jetstack-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 15, 2024
@SgtCoDFish SgtCoDFish force-pushed the feat/announcements-section branch from 4ee3595 to 19ba455 Compare March 15, 2024 11:58
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 15, 2024
@SgtCoDFish
Copy link
Member

SgtCoDFish commented Mar 15, 2024 •
edited
Loading

I changed the date and it seemed to work for me locally - we'll see how it goes and revert if needed... EDIT: It seems to work in the preview too!

I also rebased against the latest master!

wallrj
wallrj approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

image

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
SgtCoDFish
SgtCoDFish approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

(since I contributed,I can't remember if this will work. But worth a go!)

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2024
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon, SgtCoDFish, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SgtCoDFish,inteon,wallrj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@inteon
Copy link
Member

inteon commented Mar 18, 2024

/unhold
From onboard the Eurostar.

@jetstack-bot jetstack-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 18, 2024
@jetstack-bot jetstack-bot merged commit 5b9a82b into cert-manager:master Mar 18, 2024
4 checks passed
@inteon
Copy link
Member

inteon commented Mar 18, 2024

Noticed that the URL should be https://cert-manager.io/announcements/2024/03/18/cert-manager-security-audit/ instead of https://cert-manager.io/announcements/2024/21/18/cert-manager-security-audit/.
Will create a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon inteon left review comments

@wallrj wallrj wallrj approved these changes

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThatsMrTalbot @SgtCoDFish @jetstack-bot @inteon @wallrj