Various website updates #1169
Merged
Various website updates #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this was safe previously, but we added more files to reference which means that `docs/` always gets clobbered by whatever's been created for the latest version Signed-off-by: Ashley Davis <[email protected]>
Signed-off-by: Ashley Davis <[email protected]>
jetstack-bot
added
dco-signoff: yes
when a Dropdown element was embedded in another Dropdown element, a <div> tag would appear as a direct descendent of a <ul> which is invalid (since only <li> are allowed to appear in <ul>) this change embeds the dropdown in an <li> which seems to work fine in testing and fixes the invalid HTML Signed-off-by: Ashley Davis <[email protected]>
Listbox (see https://headlessui.com/react/listbox) provides certain form elements for use, which get translated into normal HTML elements it's illegal for a <label> to appear inside a <button>, so this commit removes the label entirely which seems to have no visible effects and fixes the invalid HTML that was otherwise generated Signed-off-by: Ashley Davis <[email protected]>
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
SgtCoDFish
commented
Jan 23, 2023
v1.11 CLI docs, etc have more updates because their updates weren't committed - they're regenerated at build time so the deployed version was correct, but committing here makes the repo better match reality Signed-off-by: Ashley Davis <[email protected]>
|
Thank you for these fixes @SgtCoDFish! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
inteon
reviewed
Jan 23, 2023
| <Dropdown | ||
| routes={r} | ||
| parentOpen={open} | ||
| key={`${r.title}-${idx}`} |
There was a problem hiding this comment.
@SgtCoDFish
This key is now double (on this and the parent HTML tag), not sure if that is a good/ bad thing.
There was a problem hiding this comment.
I wasn't sure either 😂 But it worked fine for me in testing so I assumed it wouldn't be a huge problem!
This was referenced Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.
#1168 describes how even after this PR, API docs are still broken - but this PR should still improve the situation by removing invalid HTML from the sidebar