Improved the summary on the docs homepage #1071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
dco-signoff: yes
wallrj
commented
Sep 7, 2022
|
/cc @jsoref In case you have a few minutes to proof read this. |
✅ Deploy Preview for cert-manager-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jsoref
reviewed
Sep 7, 2022
jetstack-bot
added
dco-signoff: no
wallrj
force-pushed
the
improved-docs-homepage
branch
from
41a3b34 to
baf88a3
Compare
jetstack-bot
added
dco-signoff: yes
inteon
reviewed
May 15, 2023
inteon
reviewed
May 15, 2023
|
@wallrj could you take a look at the comments I posted? |
jetstack-bot
removed
the
approved
Link to internal pages about each issuer Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Co-authored-by: Josh Soref <[email protected]> Signed-off-by: Richard Wall <[email protected]>
Co-authored-by: Tim Ramlot <[email protected]> Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
Signed-off-by: Richard Wall <[email protected]>
wallrj
force-pushed
the
improved-docs-homepage
branch
from
be184b7 to
bd2a79b
Compare
Signed-off-by: Richard Wall <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-1071--cert-manager-website.netlify.app/docs/
The opening paragraph of the
docs/homepage was a bit waffly,so we've tried to get straight to the point and linked to the internal pages about each supported CA rather than sending visitors off to external sites before they've read about the cert-manager integration with each of the CAs.