Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): Allow to configure automountServiceAccountToken #513

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

germanattanasio
Copy link
Contributor

@germanattanasio germanattanasio commented Dec 13, 2024

Motivation

The deployment of trust-manager in an AKS cluster raised a high-severity security finding from Azure Defender, recommending the disabling of automounted service account tokens to prevent potential misuse by compromised pods.

This PR addresses the issue by allowing users to disableautomountServiceAccountToken while enabling them to use volumes to access the token. This approach is based on the requirement that trust-manager needs the token to interact with the Kubernetes API.

With the proposed changes, you can deploy the chart using the following configuration:

automountServiceAccountToken: false
serviceAccount:
  automountServiceAccountToken: false
volumes:
- name: serviceaccount-token
  projected:
    defaultMode: 0444
    sources:
    - serviceAccountToken:
        expirationSeconds: 3607
        path: token
    - configMap:
        name: kube-root-ca.crt
        items:
        - key: ca.crt
          path: ca.crt
    - downwardAPI:
        items:
        - path: namespace
          fieldRef:
            apiVersion: v1
            fieldPath: metadata.namespace
volumeMounts:
- mountPath: /var/run/secrets/kubernetes.io/serviceaccount
  name: serviceaccount-token
  readOnly: true

Related to: cert-manager/cert-manager#5254

Changes

  • Reuse an existing service account if necessary.
  • Configure automountServiceAccountToken for both the pod and the service account.
  • Enable defining and mounting volumes in the main container.

Signed-off-by: German Attanasio [email protected]

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2024
@cert-manager-prow
Copy link
Contributor

Hi @germanattanasio. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 13, 2024
* Reuse an existing service account if needed
* Configure `automountServiceAccountToken` for the pod and service account
* Allow volumes to be defined and mounted in the main container

Signed-off-by: German Attanasio <[email protected]>
@germanattanasio
Copy link
Contributor Author

Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Hey, thanks for raising this and sorry it took a while to get eyes on it. I've enabled testing and dropped a question too!

deploy/charts/trust-manager/values.yaml Show resolved Hide resolved
@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 24, 2025
Copy link
Member

@SgtCoDFish SgtCoDFish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thank you for this, really appreciate it 🚀

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2025
@cert-manager-prow cert-manager-prow bot merged commit 00aa8c9 into cert-manager:main Jan 28, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants