Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify integration test setup #493

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Simplify integration test setup #493

merged 1 commit into from
Jan 30, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Nov 30, 2024 •
edited
Loading

After cert-manager/makefile-modules#214 is available in this project, we can simplify the integration test setup to use the generated CRD manifests.

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 30, 2024
@erikgb erikgb mentioned this pull request Nov 30, 2024
Merged
@cert-manager-prow cert-manager-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2024
@erikgb erikgb force-pushed the commit-generated-crds branch from 57b55bf to 4f90916 Compare December 8, 2024 20:43
@cert-manager-prow cert-manager-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 8, 2024
@erikgb erikgb force-pushed the commit-generated-crds branch from 4f90916 to 3d7bb9e Compare December 12, 2024 08:47
@cert-manager-prow cert-manager-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 12, 2024
@erikgb erikgb changed the title WIP: Make generated CRDs first-class citizens Simplify integration test setup Dec 12, 2024
@cert-manager-prow cert-manager-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 12, 2024
@erikgb
Simplify integration test setup
515e518 
Signed-off-by: Erik Godding Boye <[email protected]>
@erikgb erikgb force-pushed the commit-generated-crds branch from 3d7bb9e to 515e518 Compare December 13, 2024 16:07
@erikgb erikgb requested a review from inteon January 2, 2025 13:45
@inteon
Copy link
Member

inteon commented Jan 30, 2025

see cert-manager/approver-policy#551 for a similar PR.

@inteon
Copy link
Member

inteon commented Jan 30, 2025

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2025
@cert-manager-prow cert-manager-prow bot merged commit 3128f4a into cert-manager:main Jan 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inteon inteon Awaiting requested review from inteon

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikgb @inteon