Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added labels and annotations to deployment and pod #372

Merged
merged 2 commits into from
Sep 3, 2024
Merged

added labels and annotations to deployment and pod #372

merged 2 commits into from
Sep 3, 2024

Conversation

chanakya-svt
Copy link
Contributor

@chanakya-svt chanakya-svt commented Aug 5, 2024 •
edited
Loading

I am using ArgoCD to deploy the various manifests to bootstrap my cluster. As part of the deployments I am using sync-wave annotation.

Added the support to add labels and annotations to the deployment and pod.

Addresses:

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 5, 2024
@cert-manager-prow
Copy link
Contributor

Hi @chanakya-svt. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2024
@inteon inteon changed the title added labels and annottations to deployment and pod added labels and annotations to deployment and pod Aug 12, 2024
@chanakya-svt
Copy link
Contributor Author

@cm-maintainers, Can someone take a look at this one and let me know if there is anything else that needs to be done?

@SgtCoDFish
Copy link
Member

/ok-to-test

Apologies this took a while, we've had a lot of maintainers away on holiday in the past month!

@cert-manager-prow cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2024
This was referenced Sep 3, 2024
Closed
Closed
@cert-manager-prow cert-manager-prow bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2024
@SgtCoDFish SgtCoDFish force-pushed the feat/add-labels-and-annotations-to-deployment-and-pods branch from 606aa0d to 75d9fb2 Compare September 3, 2024 15:56
@cert-manager-prow cert-manager-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 3, 2024
@SgtCoDFish
Copy link
Member

/approve

I can't LGTM this now I've contributed to it, but I think we should merge and I've asked for another maintainer to review

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 3, 2024
@SgtCoDFish SgtCoDFish mentioned this pull request Sep 3, 2024
Closed
@ThatsMrTalbot
Copy link
Contributor

This seems like a good addition
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2024
@cert-manager-prow cert-manager-prow bot merged commit 6cfff77 into cert-manager:main Sep 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chanakya-svt @SgtCoDFish @ThatsMrTalbot