Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow restricting to namespace #247

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+19 −9
Open

feat: allow restricting to namespace #247

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
842a3ab
feat: Restrict to namespace from the controller level
woehrl01 Feb 16, 2023
cbb6f11
disable AWSPCAClusterIssuer if namespace restriction
woehrl01 Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion charts/aws-pca-issuer/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ service:
type: ClusterIP
port: 8080


# Options for configuring a target ServiceAccount with the role to approve
# all awspca.cert-manager.io requests.
approverRole:
Expand Down
4 changes: 4 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ func init() {

func main() {
var metricsAddr string
var restrictToNamespace string
var enableLeaderElection bool
var probeAddr string
var disableApprovedCheck bool
Expand All @@ -64,6 +65,8 @@ func main() {
"Enabling this will ensure there is only one active controller manager.")
flag.BoolVar(&disableApprovedCheck, "disable-approved-check", false,
"Disables waiting for CertificateRequests to have an approved condition before signing.")
flag.StringVar(&restrictToNamespace, "restrict-to-namespace", os.Getenv("RESTRICT_TO_NAMESPACE"),
"Restrict the controller to only process CertificateRequests in a specific namespace.")

opts := zap.Options{
Development: false,
Expand All @@ -80,6 +83,7 @@ func main() {
HealthProbeBindAddress: probeAddr,
LeaderElection: enableLeaderElection,
LeaderElectionID: "b858308c.awspca.cert-manager.io",
Namespace: restrictToNamespace,
})
if err != nil {
setupLog.Error(err, "unable to start manager")
Expand Down