Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Omit check_request params with None values #53

Merged
merged 5 commits into from
Dec 19, 2024
Merged

fix: Omit check_request params with None values #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0b3b2a1
omit check_request params with None values
Sambigeara Dec 19, 2024
d74842a
changelog
Sambigeara Dec 19, 2024
0ff0e68
formatting again
Sambigeara Dec 19, 2024
9fcf2f0
plan resources
Sambigeara Dec 19, 2024
0e756bd
format
Sambigeara Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

### Bug fixes

- Validation error path field can be empty
- Validation error path field can be empty (#52)

## v0.10.5 (2024-03-07)

Expand Down
12 changes: 10 additions & 2 deletions cerbos/sdk/_async/_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,12 @@ async def check_resources(
resources=resources.resources,
aux_data=aux_data,
)
resp = await self._http.post("/api/check/resources", json=req.to_dict())

# omit keys with `None` values
resp = await self._http.post(
"/api/check/resources",
json={k: v for k, v in req.to_dict().items() if v is not None},
)
if resp.is_error:
if self._raise_on_error:
raise CerbosRequestException(APIError.from_dict(resp.json()))
Expand Down Expand Up @@ -265,7 +270,10 @@ async def plan_resources(
aux_data=aux_data,
)

resp = await self._http.post("/api/plan/resources", json=req.to_dict())
resp = await self._http.post(
"/api/plan/resources",
json={k: v for k, v in req.to_dict().items() if v is not None},
)
if resp.is_error:
if self._raise_on_error:
raise CerbosRequestException(APIError.from_dict(resp.json()))
Expand Down
12 changes: 10 additions & 2 deletions cerbos/sdk/_sync/_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,12 @@ def check_resources(
resources=resources.resources,
aux_data=aux_data,
)
resp = self._http.post("/api/check/resources", json=req.to_dict())

# omit keys with `None` values
resp = self._http.post(
"/api/check/resources",
json={k: v for k, v in req.to_dict().items() if v is not None},
)
if resp.is_error:
if self._raise_on_error:
raise CerbosRequestException(APIError.from_dict(resp.json()))
Expand Down Expand Up @@ -265,7 +270,10 @@ def plan_resources(
aux_data=aux_data,
)

resp = self._http.post("/api/plan/resources", json=req.to_dict())
resp = self._http.post(
"/api/plan/resources",
json={k: v for k, v in req.to_dict().items() if v is not None},
)
if resp.is_error:
if self._raise_on_error:
raise CerbosRequestException(APIError.from_dict(resp.json()))
Expand Down
Loading