teuthology: Add support for seek and sync in write_file #2010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kshtsk
reviewed
Nov 13, 2024
kshtsk
reviewed
Nov 13, 2024
kshtsk
reviewed
Nov 13, 2024
kshtsk
reviewed
Nov 13, 2024
kshtsk
requested changes
Nov 13, 2024
chrisphoffman
force-pushed
the
wip-dd-syncseek
branch
from
8b5e772 to
824260d
Compare
Thanks for the review. Comments addressed and tests added. PTAL |
kshtsk
reviewed
Nov 20, 2024
Comment on lines
233
to
242
|
|
||
| @patch("teuthology.orchestra.remote.RemoteShell.write_file") | ||
| def test_write_file_offset(self, m_write_file): | ||
| self.c.write_file("filename", "content", bs=1, offset=1024) | ||
| m_write_file.assert_called_with("filename", "content", bs=1, offset=1024) | ||
|
|
||
| @patch("teuthology.orchestra.remote.RemoteShell.write_file") | ||
| def test_write_file_sync(self, m_write_file): | ||
| self.c.write_file("filename", "content", sync=True) | ||
| m_write_file.assert_called_with("filename", "content", sync=True) |
There was a problem hiding this comment.
Those are test not for the remote.write_file but for cluster.remote_write, I guess there should be new tests added to test/test_remote.py module instead.
kshtsk
reviewed
Nov 20, 2024
kshtsk
reviewed
Nov 20, 2024
teuthology/orchestra/remote.py
Outdated
| @@ -276,11 +277,20 @@ def write_file(self, path, data, sudo=False, mode=None, owner=None, | |||
| :param owner: set file owner if provided | |||
| :param mkdir: preliminary create the file directory, defaults False | |||
| :param append: append data to the file, defaults False | |||
| :param bs: write up to N bytes at a time, defaults 512 | |||
There was a problem hiding this comment.
I guess default is None, maybe just give a reference to dd, just add another line right after Write data to remote file above, like:
The data written in 512-byte blocks, provide `bs` to use bigger blocks.
kshtsk
reviewed
Nov 20, 2024
Signed-off-by: Christopher Hoffman <[email protected]>
Signed-off-by: Christopher Hoffman <[email protected]>
chrisphoffman
force-pushed
the
wip-dd-syncseek
branch
from
824260d to
0e0d40a
Compare
kshtsk
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for seek and sync in write_file.
This patch will allow for partial writes and sync on completion of write.
This is to support strided writes for cephfs on a multi-mount system.