teuthology-suite: add default machine type(smithi) #1625
Conversation
set teuthology_default_machine_type to smithi. see: ceph/teuthology#1625 Signed-off-by: Deepika Upadhyay <[email protected]>
ideepika
force-pushed
the
wip-machine-type
branch
from
1aae78d to
b07046c
Compare
ideepika
force-pushed
the
wip-machine-type
branch
from
b07046c to
b59d20a
Compare
ideepika
force-pushed
the
wip-machine-type
branch
from
b59d20a to
6b3ba72
Compare
|
@susebot run deploy |
|
I am extremely sorry about I forgot to review this PR earlier. |
|
Commit 6b3ba72 is OK. |
ideepika
force-pushed
the
wip-machine-type
branch
from
6b3ba72 to
4e49f42
Compare
updated, thanks! |
|
I'm fine with the concept. I'll leave the python review up to others. If Kyr's happy, I'm happy. |
|
@susebot run deploy |
|
Commit 4e49f42 is OK. |
|
@kshtsk good to merge? |
|
yep... |
|
ouch... probably commit message is outdated and does not correspond the patch content... |
…fied explicitly right now, users have to always pass --machine-type when scheduling a run, when not specified, command fails with no machine type specified error. Instead of failing, we can have `default_machine_type` which in our case should pick smithi, specified in /etc/teuthology.yml Signed-off-by: Deepika Upadhyay <[email protected]>
ideepika
force-pushed
the
wip-machine-type
branch
from
4e49f42 to
2a15c89
Compare
aah, sorry about that; fixed it! |
|
@susebot run deploy |
|
Commit 2a15c89 is OK. |
right now the default_machine_type fallback is set to None via some internal
mangaling, this makes users always have to pass --machine_type which mostly we
prefer to smithi's . Hence, making it a default unless otherwise, should be
helpful for users.
Signed-off-by: Deepika Upadhyay [email protected]