DNM: Multi-OS locking #1051
Open
DNM: Multi-OS locking #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zack Cerza <[email protected]>
A little pre-overhaul refactor... Signed-off-by: Zack Cerza <[email protected]>
Instead of either not specifying an OS type/version and just getting what's available - or requesting the same OS type/version for all nodes in the job, allow requesting arbitrary mixes of OSes. The path forward is going to be replacing things like: roles: - ['osd.0', 'mon.a'] - ['osd.1', 'osd.2] - ['client.0'] With things like: nodes: - os_type: ubuntu os_version: '16.04' roles: ['osd.0', 'mon.a'] - os_type: ubuntu os_version: '14.04' roles: ['osd.1', 'osd.2] - os_type: centos os_version: '7.3' roles: ['client.0'] Signed-off-by: Zack Cerza <[email protected]>
We used to use the 'targets' object to make remotes to roles. This worked fine before multi-OS locking, but broke down because of the unordered nature of dicts. Signed-off-by: Zack Cerza <[email protected]>
vasukulkarni
suggested changes
Mar 28, 2017
| assert 'targets' not in config, target_conflict_msg | ||
| if lock and 'roles' in config: | ||
| if 'nodes' in config: | ||
| log.warn( |
There was a problem hiding this comment.
I think we should exit here, It would be a user error to have both and fix them to use only one format
|
I would like to have a documentation update of how this feature looks from user point of view, 'node' format and use cases. |
|
If someone took over where @zmc left off and landed this feature, that would be a huge accomplishment IMO. This feature is sorely missing in teuthology. |
|
@vasukulkarni @zmc I'm looking into this PR, did you have any suite for testing this already? |
|
https://tracker.ceph.com/issues/43612#note-2 (agree with you @kshtsk ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been working on this for the last few days and it's close - but it needs more testing before it's merged.