Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd: fix cleanup of GroupSnapRollback and Sparsify progress callbacks #1067

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

idryomov
Copy link
Contributor

Instead of removing a respective progress callback, DiffIterate extent callback is attempted to be removed. This leaks the progress callback and on top of that it's quite possible for DiffIterate to be disrupted as cbIndex is not a unique pointer but just an integer ID.

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

New or infrequent contributors may want to review the go-ceph Developer's Guide including the section on how we track API Status and the API Stability Plan.

The go-ceph project uses mergify. View the mergify command guide for information on how to interact with mergify. Add a comment with @Mergifyio rebase to rebase your PR when github indicates that the PR is out of date with the base branch.

@idryomov idryomov added the bug label Jan 29, 2025
Instead of removing a respective progress callback, DiffIterate extent
callback is attempted to be removed.  This leaks the progress callback
and on top of that it's quite possible for DiffIterate to be disrupted
as cbIndex is not a unique pointer but just an integer ID.

Signed-off-by: Ilya Dryomov <[email protected]>
@idryomov idryomov force-pushed the wip-callbacks-defer-bug branch from 680aeb2 to 3ba1822 Compare January 29, 2025 11:24
@anoopcs9 anoopcs9 added the API This PR includes a change to the public API of a go-ceph package label Jan 29, 2025
Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, lgtm.

Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes, copy and paste strikes again.
Fix LGTM, thanks!

@phlogistonjohn phlogistonjohn added no-API This PR does not include any changes to the public API of a go-ceph package and removed API This PR includes a change to the public API of a go-ceph package labels Jan 29, 2025
@mergify mergify bot merged commit df352fd into ceph:master Jan 29, 2025
16 checks passed
@idryomov idryomov deleted the wip-callbacks-defer-bug branch January 29, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug no-API This PR does not include any changes to the public API of a go-ceph package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants