Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/admin: add more information to the Bucket struct #1058

Closed
wants to merge 1 commit into from
Closed

rgw/admin: add more information to the Bucket struct #1058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions rgw/admin/bucket.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,16 +20,19 @@ type Bucket struct {
DataExtraPool string `json:"data_extra_pool"`
IndexPool string `json:"index_pool"`
} `json:"explicit_placement"`
ID string `json:"id"`
Marker string `json:"marker"`
IndexType string `json:"index_type"`
Owner string `json:"owner"`
Ver string `json:"ver"`
MasterVer string `json:"master_ver"`
Mtime string `json:"mtime"`
CreationTime *time.Time `json:"creation_time"`
MaxMarker string `json:"max_marker"`
Usage struct {
ID string `json:"id"`
Marker string `json:"marker"`
IndexType string `json:"index_type"`
Versioned *bool `json:"versioned"`
VersioningEnabled *bool `json:"versioning_enabled"`
Copy link
Member

@clwluvw clwluvw Jan 31, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From squid Versioned and VersioningEnabled has been replaced by Versioning.

Suggested change
VersioningEnabled *bool `json:"versioning_enabled"`
VersioningEnabled *bool `json:"versioning_enabled"`
Versioning *string `json:"versioning"`

ObjectLockEnabled *bool `json:"object_lock_enabled"`
Owner string `json:"owner"`
Ver string `json:"ver"`
MasterVer string `json:"master_ver"`
Mtime string `json:"mtime"`
CreationTime *time.Time `json:"creation_time"`
MaxMarker string `json:"max_marker"`
Usage struct {
Comment on lines +23 to +35
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From unit tests point of view can we somehow verify these new fields?

RgwMain struct {
Size *uint64 `json:"size"`
SizeActual *uint64 `json:"size_actual"`
Expand Down
Loading