Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: refactor dockerfile to simplify selinux config directory creation #4991

Merged
merged 1 commit into from
Dec 9, 2024
Merged

build: refactor dockerfile to simplify selinux config directory creation #4991

merged 1 commit into from
Dec 9, 2024

Conversation

guoard
Copy link
Contributor

@guoard guoard commented Dec 2, 2024 •
edited
Loading

The change replaces mkdir || true with mkdir -p, making the directory creation more straightforward.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

@mergify mergify bot added the component/build Issues and PRs related to compiling Ceph-CSI label Dec 2, 2024
@Madhu-1 Madhu-1 requested a review from a team December 3, 2024 07:03
@nixpanic
Copy link
Member

nixpanic commented Dec 9, 2024

@Mergifyio rebase

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the dockerfile_improvement branch from 2f2fd0f to c661c38 Compare December 9, 2024 11:04
@nixpanic
Copy link
Member

nixpanic commented Dec 9, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Dec 9, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.30

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.31

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.31

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Dec 9, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Dec 9, 2024

/test ci/centos/mini-e2e/k8s-1.31

@nixpanic
Copy link
Member

nixpanic commented Dec 9, 2024

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 9, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit 1c93d9e into ceph:devel Dec 9, 2024
37 checks passed
@guoard guoard deleted the dockerfile_improvement branch December 10, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rakshith-R Rakshith-R Rakshith-R approved these changes

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
component/build Issues and PRs related to compiling Ceph-CSI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@guoard @nixpanic @ceph-csi-bot @Madhu-1 @Rakshith-R