-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase: bump ceph/ceph-csi from 28dc64dcae3cec8d11d84bdf525bda0ef757c688 to 961c0a8d85035a5ee4854e3960ce1b8df8b90166 #4878
Conversation
Bumps [ceph/ceph-csi](https://github.com/ceph/ceph-csi) from 28dc64d to 961c0a8. - [Release notes](https://github.com/ceph/ceph-csi/releases) - [Changelog](https://github.com/ceph/ceph-csi/blob/devel/docs/releases.md) - [Commits](28dc64d...961c0a8) --- updated-dependencies: - dependency-name: ceph/ceph-csi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
@@ -16,7 +16,7 @@ jobs: | |||
steps: | |||
# path to the retest action | |||
# yamllint disable-line rule:line-length | |||
- uses: ceph/ceph-csi/actions/retest@28dc64dcae3cec8d11d84bdf525bda0ef757c688 # devel | |||
- uses: ceph/ceph-csi/actions/retest@961c0a8d85035a5ee4854e3960ce1b8df8b90166 # devel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is our own repository, it should not include the commit-id, the branch name (devel
) is more appropriate.
@Nikhil-Ladha do you know how to annotate/comment this so that the security scanner accepts the branch?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, maybe we can use it like private actions:
- uses: ./actions/retest
This points to the local directory in the repository that contains the action. The repository needs to be checked out first, I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is our own repository, it should not include the commit-id, the branch name (
devel
) is more appropriate.@Nikhil-Ladha do you know how to annotate/comment this so that the security scanner accepts the branch?
Looking at the current annotation method, it seems like we can't omit a single action it has to be the whole check. Ref: https://github.com/ossf/scorecard/blob/main/config/README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or, maybe we can use it like private actions:
- uses: ./actions/retestThis points to the local directory in the repository that contains the action. The repository needs to be checked out first, I guess.
This seems like the best possible way for this case, I will send a PR to update the action to use the local directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's the PR: #4879
OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps ceph/ceph-csi from 28dc64d to 961c0a8.
Changelog
Sourced from ceph/ceph-csi's changelog.
... (truncated)
Commits
961c0a8
e2e: enable more k8s storage tests2d82ceb
rbd: move repairImageID() from rbdVolume struct to rbdImage9c567fd
doc: add cephfs vsg to readmef2bc1c6
rbd: replace Manager.DeleteVolumeGroup() by VolumeGroup.Delete()01a0ec2
util: use protobuf encoding for core k8s apis8c252d5
rbd: prevent re-use of destroyed resourcesf1379e4
rebase: update kube dep to x.31.177f8c3f
rebase: bump google.golang.org/grpc from 1.66.2 to 1.67.0ecf2503
rebase: bump github/codeql-action from 3.26.7 to 3.26.840ad416
rebase: bump the github-dependencies group with 2 updatesYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)