Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebase: bump ceph/ceph-csi from 28dc64dcae3cec8d11d84bdf525bda0ef757c688 to 961c0a8d85035a5ee4854e3960ce1b8df8b90166 #4878

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 30, 2024

Bumps ceph/ceph-csi from 28dc64d to 961c0a8.

Changelog

Sourced from ceph/ceph-csi's changelog.

Ceph CSI driver Release Process

Introduction

This document provides details about Ceph CSI driver release process.

Versioning

The Ceph CSI driver project uses semantic versioning for all releases. Semantic versions are comprised of three fields in the form:

MAJOR.MINOR.PATCH

For examples: 1.0.0, 1.0.0-rc.2.

Semantic versioning is used since the version number is able to convey clear information about how a new version relates to the previous version. For example, semantic versioning can also provide assurances to allow users to know when they must upgrade compared with when they might want to upgrade:

  • When PATCH increases, the new release contains important security fixes, general bug fixes and an upgrade is recommended.

The patch field can contain extra details after the number. Dashes denote pre-release versions.1.0.0-rc.2 in the example denotes the second release candidate for release 1.0.0.

  • When MINOR increases, the new release adds new features and it must be backward compatible.

  • When MAJOR increases, the new release adds new features, bug fixes, or both and which changes the behavior from the previous release (maybe backward incompatible).

Tagging repositories

The tag name must begin with "v" followed by the version number, conforming to the versioning requirements (e.g. a tag of v1.0.0-rc2 for version 1.0.0-rc2). This tag format is used by the GitHub action

... (truncated)

Commits
  • 961c0a8 e2e: enable more k8s storage tests
  • 2d82ceb rbd: move repairImageID() from rbdVolume struct to rbdImage
  • 9c567fd doc: add cephfs vsg to readme
  • f2bc1c6 rbd: replace Manager.DeleteVolumeGroup() by VolumeGroup.Delete()
  • 01a0ec2 util: use protobuf encoding for core k8s apis
  • 8c252d5 rbd: prevent re-use of destroyed resources
  • f1379e4 rebase: update kube dep to x.31.1
  • 77f8c3f rebase: bump google.golang.org/grpc from 1.66.2 to 1.67.0
  • ecf2503 rebase: bump github/codeql-action from 3.26.7 to 3.26.8
  • 40ad416 rebase: bump the github-dependencies group with 2 updates
  • Additional commits viewable in compare view

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [ceph/ceph-csi](https://github.com/ceph/ceph-csi) from 28dc64d to 961c0a8.
- [Release notes](https://github.com/ceph/ceph-csi/releases)
- [Changelog](https://github.com/ceph/ceph-csi/blob/devel/docs/releases.md)
- [Commits](28dc64d...961c0a8)

---
updated-dependencies:
- dependency-name: ceph/ceph-csi
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@@ -16,7 +16,7 @@ jobs:
steps:
# path to the retest action
# yamllint disable-line rule:line-length
- uses: ceph/ceph-csi/actions/retest@28dc64dcae3cec8d11d84bdf525bda0ef757c688 # devel
- uses: ceph/ceph-csi/actions/retest@961c0a8d85035a5ee4854e3960ce1b8df8b90166 # devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our own repository, it should not include the commit-id, the branch name (devel) is more appropriate.

@Nikhil-Ladha do you know how to annotate/comment this so that the security scanner accepts the branch?

Copy link
Member

@nixpanic nixpanic Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, maybe we can use it like private actions:

- uses: ./actions/retest

This points to the local directory in the repository that contains the action. The repository needs to be checked out first, I guess.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is our own repository, it should not include the commit-id, the branch name (devel) is more appropriate.

@Nikhil-Ladha do you know how to annotate/comment this so that the security scanner accepts the branch?

Looking at the current annotation method, it seems like we can't omit a single action it has to be the whole check. Ref: https://github.com/ossf/scorecard/blob/main/config/README.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or, maybe we can use it like private actions:

- uses: ./actions/retest

This points to the local directory in the repository that contains the action. The repository needs to be checked out first, I guess.

This seems like the best possible way for this case, I will send a PR to update the action to use the local directory.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the PR: #4879

Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 2, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/github_actions/ceph/ceph-csi-961c0a8d85035a5ee4854e3960ce1b8df8b90166 branch October 2, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/e2e skip running e2e CI jobs rebase update the version of an external component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants