Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: revert to 3.11-canary #4536

Merged
merged 1 commit into from
Apr 4, 2024
Merged

revert: revert to 3.11-canary #4536

merged 1 commit into from
Apr 4, 2024

Conversation

Rakshith-R
Copy link
Contributor

Describe what this PR does

This commit makes template changes for
3.11 release branch to use 3.11-canary tag.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow
    guidelines in the developer
    guide    .
  • Reviewed the developer guide on Submitting a Pull
    Request
  • Pending release
    notes
    updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

nixpanic
nixpanic previously approved these changes Apr 2, 2024
View reviewed changes
iPraveenParihar
iPraveenParihar previously approved these changes Apr 3, 2024
View reviewed changes
@Rakshith-R
Copy link
Contributor Author

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

Pull request #4536 has been dequeued, merge conditions unmatch:

  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • all of [📃 From pull request rule queue]:
    • any of [🔀 queue conditions]:
      • all of [📌 queue conditions of queue default]:
        • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
        • #approved-reviews-by>=1 [🛡 GitHub branch protection]
    • -draft [📌 queue requirement]
    • any of [📌 queue -> configuration change requirements]:
      • -mergify-configuration-changed
      • check-success=Configuration changed
  • any of:
    • all of:
      • status-success=ci/centos/k8s-e2e-external-storage/1.26
      • status-success=ci/centos/mini-e2e-helm/k8s-1.26
      • status-success=ci/centos/mini-e2e-helm/k8s-1.27
      • status-success=ci/centos/mini-e2e-helm/k8s-1.28
      • status-success=ci/centos/mini-e2e-helm/k8s-1.29
      • status-success=ci/centos/mini-e2e/k8s-1.26
      • status-success=ci/centos/mini-e2e/k8s-1.27
      • status-success=ci/centos/mini-e2e/k8s-1.28
      • status-success=ci/centos/mini-e2e/k8s-1.29
      • status-success=ci/centos/upgrade-tests-rbd
      • base~=^(release-.+)$
      • status-success=ci/centos/k8s-e2e-external-storage/1.27
      • status-success=ci/centos/k8s-e2e-external-storage/1.28
      • status-success=ci/centos/k8s-e2e-external-storage/1.29
      • status-success=ci/centos/upgrade-tests-cephfs
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
    • all of:
      • base=release-v3.10
      • status-success=ci/centos/k8s-e2e-external-storage/1.26
      • status-success=ci/centos/mini-e2e-helm/k8s-1.26
      • status-success=ci/centos/mini-e2e-helm/k8s-1.27
      • status-success=ci/centos/mini-e2e-helm/k8s-1.28
      • status-success=ci/centos/mini-e2e/k8s-1.26
      • status-success=ci/centos/mini-e2e/k8s-1.27
      • status-success=ci/centos/mini-e2e/k8s-1.28
      • status-success=ci/centos/upgrade-tests-rbd
      • status-success=ci/centos/k8s-e2e-external-storage/1.27
      • status-success=ci/centos/k8s-e2e-external-storage/1.28
      • status-success=ci/centos/upgrade-tests-cephfs
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
    • all of:
      • status-success=ci/centos/k8s-e2e-external-storage/1.26
      • status-success=ci/centos/mini-e2e-helm/k8s-1.26
      • status-success=ci/centos/mini-e2e-helm/k8s-1.27
      • status-success=ci/centos/mini-e2e-helm/k8s-1.28
      • status-success=ci/centos/mini-e2e-helm/k8s-1.29
      • status-success=ci/centos/mini-e2e/k8s-1.26
      • status-success=ci/centos/mini-e2e/k8s-1.27
      • status-success=ci/centos/mini-e2e/k8s-1.28
      • status-success=ci/centos/mini-e2e/k8s-1.29
      • status-success=ci/centos/upgrade-tests-rbd
      • base=release-v3.11
      • status-success=ci/centos/k8s-e2e-external-storage/1.27
      • status-success=ci/centos/k8s-e2e-external-storage/1.28
      • status-success=ci/centos/k8s-e2e-external-storage/1.29
      • status-success=ci/centos/upgrade-tests-cephfs
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
    • all of:
      • base=devel
      • status-success=ci/centos/mini-e2e-helm/k8s-1.27
      • status-success=ci/centos/mini-e2e-helm/k8s-1.28
      • status-success=ci/centos/mini-e2e-helm/k8s-1.29
      • status-success=ci/centos/mini-e2e/k8s-1.27
      • status-success=ci/centos/mini-e2e/k8s-1.28
      • status-success=ci/centos/mini-e2e/k8s-1.29
      • status-success=ci/centos/upgrade-tests-rbd
      • status-success=ci/centos/k8s-e2e-external-storage/1.27
      • status-success=ci/centos/k8s-e2e-external-storage/1.28
      • status-success=ci/centos/k8s-e2e-external-storage/1.29
      • status-success=ci/centos/upgrade-tests-cephfs
      • status-success=codespell
      • status-success=go-test
      • status-success=golangci-lint
      • status-success=lint-extras
      • status-success=mod-check
      • status-success=multi-arch-build
    • all of:
      • base=ci/centos
      • status-success=ci/centos/jjb-validate
      • status-success=ci/centos/job-validation
  • #approved-reviews-by>=1 [🛡 GitHub branch protection].

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Apr 3, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 3, 2024
Madhu-1
Madhu-1 requested changes Apr 3, 2024
View reviewed changes
deploy/cephfs/kubernetes/csi-cephfsplugin-provisioner.yaml
@@ -43,7 +43,7 @@ spec:
priorityClassName: system-cluster-critical
containers:
- name: csi-cephfsplugin
image: quay.io/cephcsi/cephcsi:v3.11.0
image: quay.io/cephcsi/cephcsi:v3.11-canary
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same change is required in value.yaml for both helm charts can you please check?

Madhu-1
Madhu-1 reviewed Apr 3, 2024
View reviewed changes
deploy/nfs/kubernetes/csi-nfsplugin-provisioner.yaml
@@ -120,7 +120,7 @@ spec:
- name: socket-dir
mountPath: /csi
- name: liveness-prometheus
image: quay.io/cephcsi/cephcsi:v3.11.0
image: quay.io/cephcsi/cephcsi:v3.11-canary
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about nfs plugin ds yaml?

@Rakshith-R
revert: revert to 3.11-canary
b481e4c 
This commit makes template changes for
3.11 release branch to use 3.11-canary tag.

Signed-off-by: Rakshith R <[email protected]>
@Rakshith-R
Copy link
Contributor Author

corrected, sorry for missing it.

@mergify mergify bot dismissed stale reviews from nixpanic and iPraveenParihar April 3, 2024 08:12

Pull request has been modified.

@nixpanic
Copy link
Member

nixpanic commented Apr 3, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Apr 3, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Apr 3, 2024
@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 4, 2024

/retest ci/centos/mini-e2e/k8s-1.29

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Apr 4, 2024

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 4, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 2ee72f0

@mergify mergify bot merged commit 2ee72f0 into ceph:release-v3.11 Apr 4, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

@iPraveenParihar iPraveenParihar Awaiting requested review from iPraveenParihar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Rakshith-R @ceph-csi-bot @nixpanic @Madhu-1 @iPraveenParihar