Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd: template update to support VGS #4505

Merged
merged 2 commits into from
Mar 18, 2024
Merged

rbd: template update to support VGS #4505

merged 2 commits into from
Mar 18, 2024

Conversation

iPraveenParihar
Copy link
Contributor

Describe what this PR does

This PR contains template changes to support VolumeGroupSnapshot for RBD

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next major release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.
Show available bot commands

These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:

  • /retest ci/centos/<job-name>: retest the <job-name> after unrelated
    failure (please report the failure too!)

@mergify mergify bot added the component/rbd Issues related to RBD label Mar 18, 2024
@iPraveenParihar iPraveenParihar force-pushed the rbd/template-update-for-vgs branch 2 times, most recently from c866436 to ba02c4d Compare March 18, 2024 11:01
@iPraveenParihar iPraveenParihar self-assigned this Mar 18, 2024
@iPraveenParihar iPraveenParihar marked this pull request as ready for review March 18, 2024 11:28
@iPraveenParihar
Copy link
Contributor Author

/test ci/centos/mini-e2e-helm/k8s-1.29

nixpanic
nixpanic approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@nixpanic nixpanic requested a review from a team March 18, 2024 13:30
@nixpanic nixpanic added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Mar 18, 2024
@nixpanic
Copy link
Member

@Mergifyio rebase

@iPraveenParihar @nixpanic
rbd: deployment changes to support VGS
90e7ade 
Signed-off-by: Praveen M <[email protected]>
@iPraveenParihar @nixpanic
helm: update template for rbd volumegroupsnapshot
04b8b39 
This commit updates template for rbd VolumeGroupSnapshot.
The value is set to false by default.

Signed-off-by: Praveen M <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 18, 2024

rebase

✅ Branch has been successfully rebased

@nixpanic nixpanic force-pushed the rbd/template-update-for-vgs branch from ba02c4d to 04b8b39 Compare March 18, 2024 13:48
@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 18, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Mar 18, 2024
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.29

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.29

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Mar 18, 2024
@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e/k8s-1.28

@nixpanic
Copy link
Member

/retest ci/centos/mini-e2e/k8s-1.28

Failures with CephFS and NFS, neither should be affected by this change.

logs

@nixpanic
Copy link
Member

@Mergifyio requeue

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 18, 2024

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot merged commit b9543d3 into ceph:devel Mar 18, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Madhu-1 Madhu-1 Madhu-1 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees

@iPraveenParihar iPraveenParihar

Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/rbd Issues related to RBD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iPraveenParihar @nixpanic @ceph-csi-bot @Madhu-1