Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: add extraDeploy option #4260

Merged
merged 1 commit into from
Nov 23, 2023
Merged

helm: add extraDeploy option #4260

merged 1 commit into from
Nov 23, 2023

Conversation

mustdiechik
Copy link
Contributor

To deploy additional manifests with the release.

@mergify mergify bot added the component/deployment Helm chart, kubernetes templates and configuration Issues/PRs label Nov 15, 2023
@nixpanic
Copy link
Member

Hi @mustdiechik , thanks for the PR!

Could you explain a little how this can be used, what advantage does it have? I am not very familiar with Helm common practices, so a pointer to this recommendation would help me.

Please also document the new option in the docs/deploy-*.md files, so that other users are aware of it.

@mustdiechik
Copy link
Contributor Author

mustdiechik commented Nov 16, 2023 •
edited
Loading

with this options i deploy additional PVC because I have few pools (ssd\hdd).
I will use this option to deploy calico rules for security purpose.
It is best practice to have this functionality in chart to avoid construct umbrella chart to use for deploying additional manifest.

@nixpanic
Copy link
Member

with this options i deploy additional PVC because I have few pools (ssd\hdd). I will use this option to deploy calico rules for security purpose. It is best practice to have this functionality in chart to avoid construct umbrella chart to use for deploying additional manifest.

Thanks for explaining, that sounds reasonable to me. Could you add that to the documentation, so that other users are aware of the option?

nixpanic
nixpanic reviewed Nov 21, 2023
View reviewed changes
docs/deploy-cephfs.md Outdated Show resolved Hide resolved
@nixpanic nixpanic requested a review from a team November 23, 2023 09:01
@nixpanic
Copy link
Member

@Mergifyio rebase

@mustdiechik @nixpanic
helm: add extraDeploy option
2e2ea24 
To deploy additional manifests with the release.

Signed-off-by: Ruslan Khizhnyak <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023

rebase

✅ Branch has been successfully rebased

@nixpanic
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 23, 2023 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at ec29ec1

@mergify mergify bot added the ok-to-test Label to trigger E2E tests label Nov 23, 2023
@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.26

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.27

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.28

@ceph-csi-bot
Copy link
Collaborator

/test ci/centos/mini-e2e/k8s-1.27

@ceph-csi-bot ceph-csi-bot removed the ok-to-test Label to trigger E2E tests label Nov 23, 2023
@mergify mergify bot merged commit ec29ec1 into ceph:devel Nov 23, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riya-singhal31 riya-singhal31 riya-singhal31 approved these changes

@nixpanic nixpanic nixpanic approved these changes

Assignees
No one assigned
Labels
component/deployment Helm chart, kubernetes templates and configuration Issues/PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mustdiechik @nixpanic @ceph-csi-bot @riya-singhal31