cleanup: remove left-overs of ReplicationServer in csi-common #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
previously approved these changes
Nov 3, 2023
yati1998
previously approved these changes
Nov 3, 2023
|
This pull request now has conflicts with the target branch. Could you please resolve conflicts and force push the corrected changes? 🙏 |
nixpanic
force-pushed
the
cleanup/isReplicationRequest
branch
from
a6a0d00 to
c1b4d2a
Compare
mergify
bot
dismissed stale reviews from Madhu-1 and yati1998
Pull request has been modified.
riya-singhal31
approved these changes
Nov 4, 2023
Rakshith-R
approved these changes
Nov 6, 2023
Madhu-1
approved these changes
Nov 6, 2023
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 76d9400 |
The ReplicationServer is not used anymore, the functionality has moved to CSI-Addons and the `internal/csi-addons/rbd` package. These last references were not activated anywhere, so can be removed without any impact. See-also: ceph#3314 Signed-off-by: Niels de Vos <[email protected]>
nixpanic
force-pushed
the
cleanup/isReplicationRequest
branch
from
c1b4d2a to
6d21160
Compare
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ReplicationServer is not used anymore, the functionality has moved
to CSI-Addons and the
internal/csi-addons/rbdpackage. These lastreferences were not activated anywhere, so can be removed without any
impact.
See-also: #3314