rebase: update csi spec to latest release #4203
Conversation
| @@ -94,3 +94,11 @@ func (cs *DefaultControllerServer) ControllerGetVolume( | |||
| ) (*csi.ControllerGetVolumeResponse, error) { | |||
| return nil, status.Error(codes.Unimplemented, "") | |||
| } | |||
|
|
|||
| // ControllerModifyVolume modifies existing volume. | |||
| func (cs *DefaultControllerServer) ControllerModifyVolume( | |||
There was a problem hiding this comment.
this is so ugly... Do you know why DefaultControllerServer does not extend/contain the csi.UnimplementedControllerServer so that all these functions can be removed?
There was a problem hiding this comment.
Good catch! this was missing in two places, add it and also removed unwanted methods as well.
|
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e/k8s-1.26 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
Hmm, all k8s-1.26 jobs failed. That can hardly be coincidence. But, I guess the issue is fixed. Deploying failed because downloading kubectl.sha256 fails in all cases. It works for me. |
|
/retest ci/centos/mini-e2e/k8s-1.26 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.26 |
|
/retest ci/centos/k8s-e2e-external-storage/1.26 |
|
All k8s-1.26 CI jobs failed again, with downloading |
|
/retest ci/centos/mini-e2e/k8s-1.26 |
|
/retest ci/centos/mini-e2e-helm/k8s-1.26 |
|
/retest ci/centos/k8s-e2e-external-storage/1.26 |
updating csi spec to v1.9.0 release Signed-off-by: Madhu Rajanna <[email protected]>
Add UnimplementedControllerServer to the default implementation to avoid missing method error. Signed-off-by: Madhu Rajanna <[email protected]>
As we are using UnimplementedControllerServer we dont need to implement mock methods. Signed-off-by: Madhu Rajanna <[email protected]>
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/k8s-e2e-external-storage/1.27 |
|
/test ci/centos/k8s-e2e-external-storage/1.26 |
|
/test ci/centos/k8s-e2e-external-storage/1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.27 |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/mini-e2e-helm/k8s-1.28 |
|
/test ci/centos/mini-e2e-helm/k8s-1.26 |
|
/test ci/centos/mini-e2e/k8s-1.27 |
|
/test ci/centos/mini-e2e/k8s-1.28 |
|
/test ci/centos/mini-e2e/k8s-1.26 |
updating csi spec to v1.9.0 release.