cephfs: fix fetchIP to support more formats

Signed-off-by: Riya Singhal <[email protected]>
ceph · Dec 15, 2023 · 19556c8 · 19556c8
1 parent e998330
commit 19556c8
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/internal/csi-addons/networkfence/fencing.go b/internal/csi-addons/networkfence/fencing.go
@@ -22,6 +22,7 @@ import (
 	"errors"
 	"fmt"
 	"net"
+	"regexp"
 	"strconv"
 	"strings"
 	"time"
@@ -210,11 +211,13 @@ func (ac *activeClient) fetchIP() (string, error) {
 	// example: "inst": "client.4305 172.21.9.34:0/422650892",
 	// then returning value will be 172.21.9.34
 	clientInfo := ac.Inst
-	parts := strings.Fields(clientInfo)
-	if len(parts) >= 2 {
-		lastColonIndex := strings.LastIndex(parts[1], ":")
-		firstPart := parts[1][:lastColonIndex]
-		ip := net.ParseIP(firstPart)
+
+	// Attempt to extract the IP address using a regular expression
+	re := regexp.MustCompile(`(?:[0-9a-fA-F]{1,4}:){7}[0-9a-fA-F]{1,4}|(?:\d+\.){3}\d+`)
+	ipMatches := re.FindStringSubmatch(clientInfo)
+
+	if len(ipMatches) > 0 {
+		ip := net.ParseIP(ipMatches[0])
 		if ip != nil {
 			return ip.String(), nil
 		}

diff --git a/internal/csi-addons/networkfence/fencing_test.go b/internal/csi-addons/networkfence/fencing_test.go
@@ -73,6 +73,11 @@ func TestFetchIP(t *testing.T) {
 			expectedIP:  "2001:db8:85a3::8a2e:370:7334",
 			expectedErr: false,
 		},
+		{
+			clientInfo:  "client.24152 v1:100.64.0.7:0/3658550259",
+			expectedIP:  "100.64.0.7",
+			expectedErr: false,
+		},
 		{
 			clientInfo:  "",
 			expectedIP:  "",