Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a warning cosbench will be deprecated #317

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a warning cosbench will be deprecated #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6701a0b
This change adds a warning to the README.md and cosbench benchmark cl…
lee-j-sanders Oct 9, 2024
70e48e0
Add additional comment to README.md referencing the PR in the ceph re…
lee-j-sanders Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# CBT - The Ceph Benchmarking Tool

Release v0.3 will be the final version of CBT that contains support for cosbench.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am guessing the current version is v0.3?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the current version is v0.3, See the release tag history.

There will be a PR soon that will deprecate support for cosbench. If you require
support for cosbench please continue to use v0.3.

PR https://github.com/ceph/ceph/pull/60169 implements a change to remove qa/tasks cosbench
infrastructure from the Teuthology suite. Ceph releases Quincy and newer did not have any
cosbench suite tests, since teuthology pulls the latest version of CBT and the ceph CI/CD
pipeline are run tests from teuthology for Quincy and newer, there are not any backward
compatibility issues related to removal of cosbench from CBT.

## INTRODUCTION
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is probably a good point where you can clarify the work surrounding this change (this is what I men for a link):

PR ceph/ceph#60169 on the ceph release implements the change to remove cosbench from Teuthology. There are QA tests using the cosbench CBT infrastructure I removed from PR60169.

It just makes things easier. Otherwise you need to jump across repos to track down everything is in place.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@perezjosibm Added a new commit with the README.md change referencing the PR. Please re-review thanks!


CBT is a testing harness written in python that can automate a variety of tasks
Expand Down
2 changes: 2 additions & 0 deletions benchmark/cosbench.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ def __init__(self, archive_dir, cluster, config):

config = self.parse_conf(config)

logger.warning("Cosbench support within CBT will be deprecated in a later PR. Please use release tag v0.3 for continued use of cosbench.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this warning appearing on any CBT version?

Copy link
Author

@lee-j-sanders lee-j-sanders Oct 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.3 release tag was created before this PR.

Yes, since this PR will be merged after v0.3, if you pull this PR you will get this warning to indicate cosbench support will soon be deprecated everytime you run a cosbench test.


self.op_size = config["obj_size"]
self.total_procs = config["workers"]
self.containers = config["containers_max"]
Expand Down