-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dashboard summary #2630
base: main
Are you sure you want to change the base?
Add dashboard summary #2630
Conversation
PR deployed in Google Cloud |
PR deployed in Google Cloud |
32fe42a
to
e830027
Compare
5a37f28
to
a535ffe
Compare
e830027
to
f70c459
Compare
4ae980e
to
97abeb9
Compare
useEffect(() => { | ||
if (selectedPools.length === 0 && pools.length > 0) { | ||
setSelectedPools(pools.map((pool) => pool.id)) | ||
} | ||
}, [pools.length, selectedPools.length, setSelectedPools, pools]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather see this in the selected pool context, I think it could be a valuable option to default select all pools.
https://github.com/centrifuge/apps/pull/2609/files#diff-fa36ec06969a8437b730d7d7bbbdd6736b00b791e6dbdd9eb8892ed5054cd861R15
I tried it like this, but let me know if you have a better idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you would merge investors first and I will grab your change! Thank you
;<Select | ||
options={aumOptions} | ||
onChange={(e) => setSelectedAumOption(aumOptions.find((option) => option.value === e.target.value) ?? aumOptions[0])} | ||
value={selectedAumOption.value} | ||
variant="secondary" | ||
hideBorder | ||
small | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forgot to delete maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea what this is but yeah haha
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm noticing some jumping in the table when I select different pools! You may need to nail down the width of the columns to prevent the jumping
97abeb9
to
79ea199
Compare
79ea199
to
0052e55
Compare
4899f70
to
cc2fe1f
Compare
Add new landing page for our dashboard page - it does not include the CTA drawers.
#2582