Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dashboard summary #2630

Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Add dashboard summary #2630

wants to merge 28 commits into from

Conversation

kattylucy
Copy link
Collaborator

@kattylucy kattylucy commented Feb 12, 2025

Add new landing page for our dashboard page - it does not include the CTA drawers.

#2582

Copy link

github-actions bot commented Feb 12, 2025

PR deployed in Google Cloud
URL: https://app-pr2630.k-f.dev
PINNING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/pinning-api-pr2630
ONBOARDING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/onboarding-api-pr2630
Commit #: 0fdf7da

Copy link

github-actions bot commented Feb 12, 2025

PR deployed in Google Cloud
URL: https://pr2630-app-ff-production.k-f.dev
PINNING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/pinning-api-pr2630
ONBOARDING_URL: https://europe-central2-peak-vista-185616.cloudfunctions.net/onboarding-api-pr2630
Commit #: 0fdf7da

@kattylucy kattylucy force-pushed the 2582_landing_dashboard_page branch from 5a37f28 to a535ffe Compare February 13, 2025 10:14
@kattylucy kattylucy marked this pull request as ready for review February 13, 2025 10:15
@kattylucy kattylucy force-pushed the 2582_landing_dashboard_page branch from 4ae980e to 97abeb9 Compare February 13, 2025 10:30
Comment on lines 31 to 34
useEffect(() => {
if (selectedPools.length === 0 && pools.length > 0) {
setSelectedPools(pools.map((pool) => pool.id))
}
}, [pools.length, selectedPools.length, setSelectedPools, pools])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather see this in the selected pool context, I think it could be a valuable option to default select all pools.
https://github.com/centrifuge/apps/pull/2609/files#diff-fa36ec06969a8437b730d7d7bbbdd6736b00b791e6dbdd9eb8892ed5054cd861R15
I tried it like this, but let me know if you have a better idea.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you would merge investors first and I will grab your change! Thank you

Comment on lines 1 to 8
;<Select
options={aumOptions}
onChange={(e) => setSelectedAumOption(aumOptions.find((option) => option.value === e.target.value) ?? aumOptions[0])}
value={selectedAumOption.value}
variant="secondary"
hideBorder
small
/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to delete maybe?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this is but yeah haha

Copy link
Collaborator

@sophialittlejohn sophialittlejohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm noticing some jumping in the table when I select different pools! You may need to nail down the width of the columns to prevent the jumping

@kattylucy kattylucy force-pushed the 2582_landing_dashboard_page branch from 97abeb9 to 79ea199 Compare February 13, 2025 15:51
@kattylucy kattylucy force-pushed the 2582_landing_dashboard_page branch from 79ea199 to 0052e55 Compare February 14, 2025 11:24
Base automatically changed from 2585_assets_page to main February 14, 2025 15:17
@kattylucy kattylucy force-pushed the 2582_landing_dashboard_page branch from 4899f70 to cc2fe1f Compare February 14, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants