Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: duplicate names in matrix tactics #350

Merged
merged 1 commit into from
May 23, 2024

Conversation

clemiller
Copy link
Contributor

Fixes an issue with retrieving tactics and techniques within a matrix when it contains tactics with duplicate names.

The matrix service builds the matrix by tactic, sequentially retrieving each tactic object and its techniques, and then maps the tactics by name (rather than by a unique ID). This causes subsequent tactics to be re-mapped/overwrite previous tactics with the same name and the matrix does not build as expected on the front end (appearing to have missing tactics/techniques).

@clemiller clemiller requested a review from ElJocko May 23, 2024 14:35
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 67.48%. Comparing base (1c28982) to head (60700c7).

Files Patch % Lines
app/services/matrices-service.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #350   +/-   ##
========================================
  Coverage    67.48%   67.48%           
========================================
  Files          130      130           
  Lines        17596    17596           
  Branches      2260     2260           
========================================
  Hits         11875    11875           
  Misses        5713     5713           
  Partials         8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElJocko ElJocko merged commit 828d031 into develop May 23, 2024
3 of 4 checks passed
@ElJocko ElJocko deleted the fix-retrieve-techniques-for-matrix branch May 23, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants