Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored teams service #348

Merged
merged 18 commits into from
Mar 6, 2024
Merged

Refactored teams service #348

merged 18 commits into from
Mar 6, 2024

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Mar 1, 2024

No description provided.

@vsun757 vsun757 requested a review from ElJocko March 1, 2024 17:14
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 62.02186% with 139 lines in your changes are missing coverage. Please review.

Project coverage is 70.39%. Comparing base (914a510) to head (7f3178d).
Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/services/teams-service.js 57.14% 60 Missing ⚠️
app/controllers/teams-controller.js 48.68% 39 Missing ⚠️
app/repository/teams-repository.js 71.20% 36 Missing ⚠️
app/exceptions/index.js 85.71% 2 Missing ⚠️
app/repository/user-accounts-repository.js 50.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #348      +/-   ##
=================================================
+ Coverage          70.26%   70.39%   +0.13%     
=================================================
  Files                151      151              
  Lines              14365    14373       +8     
  Branches            1667     1660       -7     
=================================================
+ Hits               10093    10118      +25     
+ Misses              4262     4245      -17     
  Partials              10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ElJocko ElJocko merged commit 944e251 into project-orion Mar 6, 2024
2 of 4 checks passed
@ElJocko ElJocko deleted the 289-refactor-teams branch March 6, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants