Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored collection indexes service for improved structure and asynchronicity #347

Open
wants to merge 9 commits into
base: project-orion
Choose a base branch
from

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Feb 26, 2024

No description provided.

@vsun757 vsun757 requested a review from ElJocko February 26, 2024 21:30
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 61.83746% with 108 lines in your changes are missing coverage. Please review.

Project coverage is 70.43%. Comparing base (ca9e552) to head (aad6dd4).
Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/repository/collection-index-repository.js 57.05% 67 Missing ⚠️
app/controllers/collection-indexes-controller.js 50.68% 36 Missing ⚠️
app/services/collection-indexes-service.js 90.74% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #347      +/-   ##
=================================================
+ Coverage          70.20%   70.43%   +0.22%     
=================================================
  Files                150      151       +1     
  Lines              14393    14417      +24     
  Branches            1671     1667       -4     
=================================================
+ Hits               10105    10154      +49     
+ Misses              4278     4253      -25     
  Partials              10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant