Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor useraccounts service for improved structure and asynchronicity #344

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Feb 14, 2024

No description provided.

@vsun757 vsun757 requested a review from ElJocko February 14, 2024 21:11
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
29.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 165 lines in your changes are missing coverage. Please review.

Comparison is base (311bfba) 69.46% compared to head (ca9e552) 70.20%.
Report is 1 commits behind head on project-orion.

Files Patch % Lines
app/services/user-accounts-service.js 60.20% 76 Missing ⚠️
app/repository/user-accounts-repository.js 60.40% 59 Missing ⚠️
app/controllers/user-accounts-controller.js 47.27% 29 Missing ⚠️
app/services/teams-service.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #344      +/-   ##
=================================================
+ Coverage          69.46%   70.20%   +0.74%     
=================================================
  Files                150      150              
  Lines              14496    14393     -103     
  Branches            1665     1671       +6     
=================================================
+ Hits               10069    10105      +36     
+ Misses              4416     4278     -138     
+ Partials              11       10       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElJocko ElJocko merged commit 1f2b445 into project-orion Feb 14, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants