Refactor attack objects service for improved structure and asynchronicity #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## project-orion #343 +/- ##
=================================================
+ Coverage 70.20% 70.26% +0.05%
=================================================
Files 150 151 +1
Lines 14393 14365 -28
Branches 1671 1667 -4
=================================================
- Hits 10105 10093 -12
+ Misses 4278 4262 -16
Partials 10 10 ☔ View full report in Codecov by Sentry. |
…for-improved-structure-and-asynchronicity
Remove redundant code. Modify attack objects repository so that the base service can be used for the retrieveAll() function. Avoid using the AttackObject model in the service.
|
seansica
deleted the
307-refactor-attackobjects-service-for-improved-structure-and-asynchronicity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.