Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored identities service for improved structure and asynchronicity #342

Conversation

vsun757
Copy link

@vsun757 vsun757 commented Jan 25, 2024

No description provided.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 155 lines in your changes are missing coverage. Please review.

Comparison is base (d721767) 69.09% compared to head (61b0864) 69.07%.
Report is 1 commits behind head on project-orion.

❗ Current head 61b0864 differs from pull request most recent head 311bfba. Consider uploading reports for the commit 311bfba to get more accurate results

Files Patch % Lines
app/services/identities-service.js 59.92% 109 Missing ⚠️
app/controllers/identities-controller.js 53.06% 46 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           project-orion     #342      +/-   ##
=================================================
- Coverage          69.09%   69.07%   -0.02%     
=================================================
  Files                149      150       +1     
  Lines              14777    14708      -69     
  Branches            1713     1700      -13     
=================================================
- Hits               10210    10160      -50     
+ Misses              4556     4537      -19     
  Partials              11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

vsun757 and others added 3 commits January 26, 2024 08:46
Remove calls to repository.model functions and use the repository functions instead.
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@ElJocko ElJocko merged commit 271a806 into project-orion Jan 29, 2024
1 of 2 checks passed
@ElJocko ElJocko deleted the 299-refactor-identities-service-for-improved-structure-and-asynchronicity branch January 29, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants